[PATCH] D94092: [Clang] Remove unnecessary Attr.isArgIdent checks.

Tue Jan 5 08:56:34 PST 2021

erichkeane added a comment.

In D94092#2479733 <https://reviews.llvm.org/D94092#2479733>, @fhahn wrote:

> In D94092#2479684 <https://reviews.llvm.org/D94092#2479684>, @erichkeane wrote:
>
>> I'm not sure how well Attr.td's constraints are enforced on type attributes, as these often happen before parsing is completely done.  I'd imagine this code was put into place at least the 1st time for good reason, but I'm curious as to why we wouldn't have tests that cover that (or, as you assert, it could simply be that this is simply dead code).
>>
>> I'm generally OK with this (the asserts are unnecessary), but would like @aaron.ballman to double check my expectations here.
>
> It would be great if we could get confirmation!
>
> I tried a few different things to construct matrix_type attributes with ArgIdents, but failed. The patch also adjusts the code for a bunch of attributes. So if there are indeed cases where ArgIdents can show up, we will get some examples for unit tests.

The comment claims: "// Special case where the argument is a template id.".  I would expect one of the following to hit that:
https://godbolt.org/z/znYW1s

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94092/new/

https://reviews.llvm.org/D94092