[PATCH] D94092: [Clang] Remove unnecessary Attr.isArgIdent checks.

[Florian Hahn via Phabricator via cfe-commits]

fhahn updated this revision to Diff 314635.
fhahn added a comment.



In D94092#2479684 <https://reviews.llvm.org/D94092#2479684>, @erichkeane wrote:

> I'm not sure how well Attr.td's constraints are enforced on type attributes, as these often happen before parsing is completely done.  I'd imagine this code was put into place at least the 1st time for good reason, but I'm curious as to why we wouldn't have tests that cover that (or, as you assert, it could simply be that this is simply dead code).
>
> I'm generally OK with this (the asserts are unnecessary), but would like @aaron.ballman to double check my expectations here.

It would be great if we could get confirmation!

I tried a few different things to construct matrix_type attributes with ArgIdents, but failed. The patch also adjusts the code for a bunch of attributes. So if there are indeed cases where ArgIdents can show up, we will get some examples for unit tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94092/new/

https://reviews.llvm.org/D94092

Files:
  clang/lib/Sema/SemaType.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94092.314635.patch
Type: text/x-patch
Size: 4300 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210105/1ac3e644/attachment.bin>