[PATCH] D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize
Peter Waller via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jan 5 08:39:21 PST 2021
peterwaller-arm marked an inline comment as done.
peterwaller-arm added inline comments.
================
Comment at: llvm/test/Transforms/InstCombine/debuginfo-scalable-typesize.ll:13
+
+; ERR-NOT: TypeSize is not scalable
+
----------------
peterwaller-arm wrote:
> sdesmalen wrote:
> > After your changes, what line causes this warning to be emitted? Does this test also pass with asserts enabled?
> It's a -NOT check, so it's not being emitted. Yes, the test passes even with asserts enabled.
>
> I assume the question is motivated by putting the check next to the line which causes the warning(?).
Discussed out of band. Sander's interest was to disallow any warning output, as with other SVE ASM-NOT tests in the clang directory.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91806/new/
https://reviews.llvm.org/D91806
More information about the cfe-commits
mailing list