[PATCH] D93014: [Clang] Add AArch64 VCMLA LANE variants.

[Sjoerd Meijer via Phabricator via cfe-commits]

SjoerdMeijer accepted this revision.
SjoerdMeijer added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/include/clang/Basic/arm_neon.td:1911
+    // vcmlaq{ROT}_lane
+    def : SOpInst<"vcmla" # ROT # "_lane", "...qI", "Q" # type, Op<(call "vcmla" # ROT, $p0, $p1,
+           (bitcast $p0, (dup_typed laneqty , (call "vget_lane", (bitcast lanety, $p2), $p3))))>>;
----------------
fhahn wrote:
> SjoerdMeijer wrote:
> > I have looked only quickly at this, but I was expecting the `"q"` to appear here somewhere?
> Yes that is indeed a bit surprising. But the tablegen emitter has code that inserts the `q` automatically, if required, which kicks in here. (https://github.com/llvm/llvm-project/blob/main/clang/utils/TableGen/NeonEmitter.cpp#L1087)
Ok, thanks, LGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93014/new/

https://reviews.llvm.org/D93014