[PATCH] D94019: Switching Clang UniqueInternalLinkageNamesPass scheduling to using the LLVM one with newpm.
David Blaikie via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jan 4 18:32:53 PST 2021
dblaikie added a comment.
In D94019#2478378 <https://reviews.llvm.org/D94019#2478378>, @aeubanks wrote:
> Oh sorry, yeah this isn't NFC.
>
> But I still don't think this needs a new test. We're going from a custom Clang implementation of adding passes to something more generic that's also more tested within LLVM.
> So IMO we just need an end to end test, which we already have in unique-internal-linkage-names.cpp. The details are tested on the LLVM side.
Then could the end to end test be tightened up to demonstrate how this patch/the change in pass order has produced new/different/desired behavior?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94019/new/
https://reviews.llvm.org/D94019
More information about the cfe-commits
mailing list