[PATCH] D92762: [clang][AArch64][SVE] Avoid going through memory for coerced VLST arguments

Cullen Rhodes via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 4 05:01:16 PST 2021


c-rhodes accepted this revision.
c-rhodes added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/CodeGen/CGCall.cpp:2706
+            ArgVals.push_back(ParamValue::forDirect(Builder.CreateExtractVector(
+                VecTyTo, Coerced, Zero, "castScalableSve")));
+            break;
----------------
nit: I know we've used `cast<Fixed|Scalable>Sve` for `Name` in a couple of places already and it's not very descriptive, but I think it describes the type being cast to, in which case this should be `castFixedSve`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92762/new/

https://reviews.llvm.org/D92762



More information about the cfe-commits mailing list