[PATCH] D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate

Mon Jan 4 04:15:08 PST 2021

DavidTruby marked an inline comment as done.
DavidTruby added inline comments.

================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:5158-5160
       // For compatibility with GCC, ignore empty bitfields in C++ mode.
       if (getContext().getLangOpts().CPlusPlus &&
           FD->isZeroLengthBitField(getContext()))
----------------
rnk wrote:
> This check seems suspect. I'd suggest constructing a test case involving zero width bitfields to see if we are compatible with MSVC.
I can add tests for this but I think it should go into a separate patch as it's not behaviour changed by this patch

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92751/new/

https://reviews.llvm.org/D92751