[PATCH] D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize

[Peter Waller via Phabricator via cfe-commits]

peterwaller-arm added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/debuginfo-scalable-typesize.ll:13
+
+; ERR-NOT: TypeSize is not scalable
+
----------------
sdesmalen wrote:
> After your changes, what line causes this warning to be emitted? Does this test also pass with asserts enabled?
It's a -NOT check, so it's not being emitted. Yes, the test passes even with asserts enabled.

I assume the question is motivated by putting the check next to the line which causes the warning(?).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91806/new/

https://reviews.llvm.org/D91806