[PATCH] D72281: [Matrix] Add matrix type to Clang.
Florian Hahn via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Jan 3 12:16:59 PST 2021
fhahn added inline comments.
================
Comment at: clang/lib/Sema/SemaType.cpp:7855
+ return;
+ RowsExpr = Columns.get();
+ } else {
----------------
RKSimon wrote:
> @fhahn Should this be ColsExpr?
> ```
> ColsExpr = Columns.get();
> ```
> Noticed when looking at https://llvm.org/reports/scan-build/report-SemaType.cpp-BuildMatrixType-11-1.html#EndPath
Thanks for pointing that out! Looks like a copy-paste error. I am just trying to come up with a test that actually exercises this code path (or remove it all together).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72281/new/
https://reviews.llvm.org/D72281
More information about the cfe-commits
mailing list