[PATCH] D93938: [clang-format] Fixed AfterEnum handling
Ally Tiritoglu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Jan 3 10:19:36 PST 2021
atirit added a comment.
In D93938#2476519 <https://reviews.llvm.org/D93938#2476519>, @MyDeveloperDay wrote:
> You need to have these conversations by adding new unit tests that prove your point, I highly doubt I'll personally be willing to accept any revision without more unit tests than this one line change
And that's why I said:
> I think accepting a revision that includes only a fix for AfterEnum being ignored (not the corner case) **and the new unit test** would be the best way to go about this.
Obviously the current revision isn't sufficient. I'll be submitting a new one shortly.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93938/new/
https://reviews.llvm.org/D93938
More information about the cfe-commits
mailing list