[PATCH] D93938: [clang-format] Fixed AfterEnum handling
Björn Schäpers via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Jan 3 05:14:48 PST 2021
HazardyKnusperkeks added a comment.
In D93938#2476432 <https://reviews.llvm.org/D93938#2476432>, @atirit wrote:
> I think accepting a revision that includes only a fix for `AfterEnum` being ignored (not the corner case) and the new unit test would be the best way to go about this, since they're separate bugs. Then I can fix the corner case (and compatibility with the new unit test) in a separate differential.
>
> However, as I've already mentioned, I'm new here, so I defer to the judgment of those more experienced.
I'm also quite new, but if that are different issues they should receive their own commit (and thus review).
You should always be clear what is not working correctly and reflect that's working after your change with tests which illustrate the now working code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93938/new/
https://reviews.llvm.org/D93938
More information about the cfe-commits
mailing list