[PATCH] D93938: [clang-format] Fixed AfterEnum handling

[MyDeveloperDay via Phabricator via cfe-commits]

MyDeveloperDay added a comment.

I think we are missing some clarity in this bug as to what the actual problem is, I do agree the test looks wrong,

This seems to be that in "Attach" mode, then AllowShortEnumsOnASingleLine=false doesn't attach the brace.

I'm somewhat struggling to understand how the code change fixes that.. given that Style.BraceWrapping.AfterEnum should be true correct?



================
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1305
+      if (!Style.isCpp()) {
         addUnwrappedLine();
         return;
----------------
surely this means always add a newline? but that isn't what is wanted from what I can tell.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93938/new/

https://reviews.llvm.org/D93938