[PATCH] D93952: [Clang][Misc] Fix fragile test

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 31 11:19:26 PST 2020


MaskRay added inline comments.


================
Comment at: clang/test/Misc/loop-opt-setup.c:1
-// RUN: %clang -O1 -fno-unroll-loops -S -o - %s -emit-llvm | FileCheck %s
+// This relies on %clang_cc1, %clang does not emit the block names in Release mode.
+// RUN: %clang_cc1 -O1 -fno-unroll-loops -S -o - %s -emit-llvm | FileCheck %s
----------------
Most tests use %clang_cc1 for relatively stable flag behavior so this comment is not needed.

The comment should mention the purpose of this test and probably why -O1 is used.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93952/new/

https://reviews.llvm.org/D93952



More information about the cfe-commits mailing list