[PATCH] D93952: [Clang][Misc] Fix fragile test
Fangrui Song via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Dec 31 10:16:28 PST 2020
MaskRay added a comment.
In D93952#2475762 <https://reviews.llvm.org/D93952#2475762>, @atmnpatel wrote:
> Ah I see, I was never able to find clear documentation on what exactly the -cc1 flag does other than the conceptual description. This should fix it right?
-cc1 options are implementation details and are unstable. Driver options need to be more stable and usually cannot be removed.
Ah I forgot that the driver option's default `-f[no-]discard-value-names` is dependent on `-DLLVM_ENABLE_ASSERTIONS`.
Can you also update the summary of this Diff and add a file-level comment to the test?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93952/new/
https://reviews.llvm.org/D93952
More information about the cfe-commits
mailing list