[PATCH] D93942: [OpenCL] Improve online documentation.

Thu Dec 31 05:05:42 PST 2020

Anastasia marked an inline comment as done.
Anastasia added inline comments.

================
Comment at: clang/docs/UsersManual.rst:2864-2868
+Adds builtin function declarations during compilations. By default
+the OpenCL headers are not loaded and therefore the builtin functions
+ are not declared. To load them automatically this flag can be
+passed to the frontend (see also :ref:`the section on the OpenCL Header
+<opencl_header>`):
----------------
mantognini wrote:
> This also applies to types I believe (e.g. int2). Maybe this paragraph should be slightly altered to reflect this?
Good point. I added types in too.

The header contains only a few types but mainly functions but vector types are important for example. Although they should have been native keywords and they were until some refactoring was made.

================
Comment at: clang/docs/UsersManual.rst:2894

-Disables support of OpenCL extensions. All OpenCL targets provide a list
+Disables support of OpenCL extensions. All OpenCL targets set a list
 of extensions that they support. Clang allows to amend this using the ``-cl-ext``
----------------
mantognini wrote:
> I feel "provide" was slightly better.
True, now that I think about this from the user's perspective it's a better wording indeed.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93942/new/

https://reviews.llvm.org/D93942