[PATCH] D93952: [Clang][Misc] Fix fragile test

Florian Hahn via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 31 04:24:44 PST 2020


fhahn added a comment.

In D93952#2475526 <https://reviews.llvm.org/D93952#2475526>, @atmnpatel wrote:

> I can't say that I know with any certainty, I'm too inexperienced. This failure was missed by me locally, the pre-merge bot, and by most of the buildbots other than the ones I mentioned above. I have no idea under what configuration of CMake options will clang not emit this particular case of a label for a BB.

The problem is that this test is using `%clang` instead of `%clang_cc1`. Executing `clang` directly will pass `-fdiscard-value-names` when built with release mode; all blocks/values will be numbered, instead of explicitly named. It would be better to update the test to use `%clang_cc1`, to make it independent on flags passed depending on configuration of clang.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93952/new/

https://reviews.llvm.org/D93952



More information about the cfe-commits mailing list