[PATCH] D91348: [OpenCL] Warn about side effects for unevaluated vec_step arg

[Sven van Haastregt via Phabricator via cfe-commits]

svenvh added a comment.

In D91348#2475646 <https://reviews.llvm.org/D91348#2475646>, @Anastasia wrote:

> LGTM, the change seems reasonable. Thanks!
>
>> A minor side-effect of this change is that it also produces the
>> warning for co_await and co_yield now.
>
> This warning is produced for **sizeof** and it seems like a duplication of another diagnostic that occurs for this case.

It aligns the note diagnostics for `sizeof` and `vec_step` for this case indeed.

> Btw just a suggestion - it is better to upload a full diff because the regular diff is not reliable in the Phabricator as line numbers change quickly in the repository and there is no information on the parent commit for the patch.

Apologies, I normally do so but forgot to provide the full context this time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91348/new/

https://reviews.llvm.org/D91348