[PATCH] D93940: [clang-tidy] Add a check for blocking types and functions.

Vasily Kulikov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 30 11:38:21 PST 2020


segoon added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/concurrency/AsyncBlockingCheck.cpp:35
+    /* C++ std */
+    "std::mutex",                 //
+    "std::timed_mutex",           //
----------------
njames93 wrote:
> Is it wise to fully qualify these?
> `::std::mutex`
> 
> Also whats with the comments at the end of each line, they don't seem to add anything.
the comments signal clang-format not to join multiple items into a single line


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93940/new/

https://reviews.llvm.org/D93940



More information about the cfe-commits mailing list