[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 28 07:28:54 PST 2020


MyDeveloperDay added inline comments.


================
Comment at: clang/include/clang/Format/Format.h:68
+  /// \endcode
+  bool InsertEmptyLineBeforeAccessModifier;
+
----------------
HazardyKnusperkeks wrote:
> MyDeveloperDay wrote:
> > quite a mouthful... maybe just `NewLineBeforeAccessModifier` ?
> A new line is always there, how about `EmptyLineBeforeAccessModifier`?
> 
> Apart from that, I would prefer an alphabetical sorting of the member, most of them are (not all I know...).

Yes `EmptyLine` seems the better termininology


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93846/new/

https://reviews.llvm.org/D93846



More information about the cfe-commits mailing list