[PATCH] D93586: [InstCombine] use poison as placeholder for undemanded elems

Nikita Popov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Dec 27 14:11:44 PST 2020


nikic added a comment.

In D93586#2472314 <https://reviews.llvm.org/D93586#2472314>, @aqjune wrote:

> There are 3 more patches:
>
> https://reviews.llvm.org/D93793 (IRBuilder's CreateVectorSplat)
> https://reviews.llvm.org/D93817 (Other transformations) 
> https://reviews.llvm.org/D93818 (LangRef)
>
> Would it be desirable if I land all of these at once as well as this (93586) when they are accepted, or is incrementally landing accepted patches okay?

Unless I'm missing something, this patch in particular is a pure optimization improvement, that does not change semantics, so I don't see a problem with landing it right away.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93586/new/

https://reviews.llvm.org/D93586



More information about the cfe-commits mailing list