[PATCH] D93806: [clang-format] PR48569 clang-format fails to align case label with `switch` with Whitesmith Indentation

Marek Kurdej via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 25 11:04:35 PST 2020


curdeius accepted this revision.
curdeius added a comment.

It would be great if we had some spec for this style, it gets a bit hard to verify if the formatting is actually what is expected.
Having said that, LGTM if the bug reporter confirms the behaviour is ok.



================
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2248
+
+  bool RemoveWhiteSmithCaseIndent =
+      (!Style.IndentCaseBlocks &&
----------------
Nit: the style is named `Whitesmiths` so I'd expect the variable to match that: small s in the middle, trailing s.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93806/new/

https://reviews.llvm.org/D93806



More information about the cfe-commits mailing list