[PATCH] D93793: [IR] Let IRBuilder's CreateVectorSplat use poison as inselt's placeholder

Juneyoung Lee via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 25 09:10:46 PST 2020


aqjune added inline comments.


================
Comment at: llvm/lib/IR/IRBuilder.cpp:1021
   Value *Zeros = ConstantAggregateZero::get(VectorType::get(I32Ty, EC));
   return CreateShuffleVector(V, Undef, Zeros, Name + ".splat");
 }
----------------
nlopes wrote:
> while at it, don't you want to change this one to poison as well?
It would be great, but there are many other places that create shufflevector with undef args (InstCombineCalls, etc). Since this and related patches are big changes, I think it might be good to land these first.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93793/new/

https://reviews.llvm.org/D93793



More information about the cfe-commits mailing list