[PATCH] D93800: [clangd][WIP] Add caching behaviour for clang-format config

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 24 03:26:50 PST 2020


njames93 created this revision.
njames93 added reviewers: sammccall, kadircet, hokein.
Herald added subscribers: usaxena95, arphaman, mgorny.
njames93 requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang.

I'm not super happy with this implementation right now, this is more a proof of concept, get it working kind of thing.
This does mimick the pattern that clang-format appears to use for grabbing its configuration albeit this goes straight to looking for config files in the directory rather than using the DefaultFormatStyle.

Although this is a large change. alot of modifications relate to the Tests being updated to this interface, I'd like to figure out how to minimise the changes and streamline the tests, but I'm not entirely sure the best way to go about that.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D93800

Files:
  clang-tools-extra/clangd/CMakeLists.txt
  clang-tools-extra/clangd/ClangdServer.cpp
  clang-tools-extra/clangd/ClangdServer.h
  clang-tools-extra/clangd/CodeComplete.cpp
  clang-tools-extra/clangd/Compiler.h
  clang-tools-extra/clangd/FormatProvider.cpp
  clang-tools-extra/clangd/FormatProvider.h
  clang-tools-extra/clangd/Hover.cpp
  clang-tools-extra/clangd/Hover.h
  clang-tools-extra/clangd/ParsedAST.cpp
  clang-tools-extra/clangd/SourceCode.cpp
  clang-tools-extra/clangd/SourceCode.h
  clang-tools-extra/clangd/tool/Check.cpp
  clang-tools-extra/clangd/tool/ClangdMain.cpp
  clang-tools-extra/clangd/unittests/ClangdTests.cpp
  clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp
  clang-tools-extra/clangd/unittests/HoverTests.cpp
  clang-tools-extra/clangd/unittests/PreambleTests.cpp
  clang-tools-extra/clangd/unittests/TestTU.cpp
  clang-tools-extra/clangd/unittests/TestTU.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D93800.313681.patch
Type: text/x-patch
Size: 39801 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201224/85855a2d/attachment-0001.bin>


More information about the cfe-commits mailing list