[PATCH] D93586: [InstCombine] use poison as placeholder for undemanded elems

Wed Dec 23 19:43:43 PST 2020

aqjune added a comment.

In D93586#2468350 <https://reviews.llvm.org/D93586#2468350>, @spatel wrote:

> It would be good to update those for consistency; the codegen tests are supposed to be representative of what comes out of the IR optimizer. IIUC, we could do the substitution on those files already, and it would not change anything. But let's sort out the IR changes first?

Yep, let's start with IR changes first. I made undef->poison test commits already.

> In D93586#2466284 <https://reviews.llvm.org/D93586#2466284>, @aqjune wrote:
>
>> 
>
> Yes, tests that don't have scripted CHECK lines require more work to understand. That SLP test file is scripted though. Is there another problem with that one?

Oh, I simply meant that replacing "insertelement undef" with "insertelement poison" won't work when updating CHECK part of non-scripted tests.
It seems things are okay because there aren't too many tests needed to be fixed.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93586/new/

https://reviews.llvm.org/D93586