[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

[Arthur Eubanks via Phabricator via cfe-commits]

aeubanks added inline comments.


================
Comment at: llvm/test/Transforms/UniqueLinkageNames/unique-internal-linkage-names.ll:20
+
+!0 = distinct !DICompileUnit(language: DW_LANG_C99, file: !1, enums: !2)
+!1 = !DIFile(filename: "test.c", directory: "")
----------------
is the debug info necessary for the test? it passes without it.


================
Comment at: llvm/test/Transforms/UniqueLinkageNames/unique-internal-linkage-names.ll:39
+
+; O0: Running pass: VerifierPass
+; O0: Running analysis: VerifierAnalysis
----------------
I don't think we need to check for Verifiers


================
Comment at: llvm/test/Transforms/UniqueLinkageNames/unique-internal-linkage-names.ll:44
+
+; O2: Running pass: ForceFunctionAttrsPass
+; O2: Running pass: UniqueInternalLinkageNamesPass
----------------
why check ForceFunctionAttrsPass?


================
Comment at: llvm/test/Transforms/UniqueLinkageNames/unique-internal-linkage-names.ll:47
+; O2: Invalidating analysis: VerifierAnalysis
+; O2: Running pass: SampleProfileProbePass
+
----------------
should this be run for O0?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93656/new/

https://reviews.llvm.org/D93656