[PATCH] D93273: [CodeGen][ObjC] Destroy callee-destroyed arguments in the caller function when the receiver is nil

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 23 14:51:03 PST 2020


rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.

Functionally LGTM.  Minor suggestion.



================
Comment at: clang/lib/CodeGen/CGObjCMac.cpp:2169
+  return false;
+}
+
----------------
Is this something that could reasonably just be a method on `ParmVarDecl`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93273/new/

https://reviews.llvm.org/D93273



More information about the cfe-commits mailing list