[PATCH] D93758: [format][NFC] Use unsigned char as the base of all enums in FormatStyle

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 23 08:07:56 PST 2020


MyDeveloperDay added a comment.

I don't have any major issues with this other than it makes Format.h a bit more ugly. (there are more ugly and harder to understand pieces of code than this change!)

We'll only normally really have 1 of these in play at any one time, but it is passed around quite a bit on the stack, should we care about the extra space it's taking?  (I'm ok if the answer is "yes we should")


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93758/new/

https://reviews.llvm.org/D93758



More information about the cfe-commits mailing list