[PATCH] D93401: [flang][driver] Add support for `-D`, `-U`

Faris via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 23 04:15:50 PST 2020


FarisRehman updated this revision to Diff 313532.
FarisRehman marked 5 inline comments as done.
FarisRehman added a comment.

Address review comments

This revision addresses comments by @awarzynski

Summary of changes:

- Update commit summary
- Use Doxygen style for input/output parameters
- Make method and variable names lowercase where required
- Remove unnecessary lines in added tests
- Update multiline macro test to have a stronger test


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93401/new/

https://reviews.llvm.org/D93401

Files:
  clang/include/clang/Driver/Options.td
  clang/lib/Driver/ToolChains/Flang.cpp
  clang/lib/Driver/ToolChains/Flang.h
  flang/include/flang/Frontend/CompilerInstance.h
  flang/include/flang/Frontend/CompilerInvocation.h
  flang/include/flang/Frontend/PreprocessorOptions.h
  flang/lib/Frontend/CompilerInstance.cpp
  flang/lib/Frontend/CompilerInvocation.cpp
  flang/test/Flang-Driver/driver-help-hidden.f90
  flang/test/Flang-Driver/driver-help.f90
  flang/test/Flang-Driver/macro_def_undef.f90
  flang/test/Flang-Driver/macro_multiline.f90

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D93401.313532.patch
Type: text/x-patch
Size: 17671 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201223/cf6690f4/attachment-0001.bin>


More information about the cfe-commits mailing list