[PATCH] D93701: [clang][cli] NFC: Make Diags optional in normalizer

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 22 23:15:43 PST 2020


dexonsmith added a comment.

> This is needed for a future patch, where we start using normalizers in contexts where no Diags are available.

Can you explain what those contexts are? I'm wondering if they can be changed to create a `DiagnosticsEngine` instead of having to account for it being maybe missing in all these places.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93701/new/

https://reviews.llvm.org/D93701



More information about the cfe-commits mailing list