[PATCH] D89617: Prepend "uniq" to symbol names hash with -funique-internal-linkage-names

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 22 16:04:27 PST 2020


MaskRay added a comment.

`.L` prefixed symbols will be discarded by the linker in the default mode (none of `--discard-none/--discard-locals/--discard-all` is specified).
So if you use `.L` (called PrivateGlobalPrefix in MC), this will work without any linker change (if possible I would hope we just make use of existing conventions instead of adding more linker rules).
For the string `__uniq` and `__part`, I am fine with them and actually prefer them if you have measured that they don't cause too mush bloat. The names are clearer than other alternatives like unary coding and special code points (e.g. LLVM IR names make use of `\1`)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89617/new/

https://reviews.llvm.org/D89617



More information about the cfe-commits mailing list