[PATCH] D93490: [clang-format] PR48539 ReflowComments breaks Qt translation comments

Tue Dec 22 14:09:50 PST 2020

HazardyKnusperkeks accepted this revision.
HazardyKnusperkeks added a comment.
This revision is now accepted and ready to land.

This looks good to me.

In D93490#2468351 <https://reviews.llvm.org/D93490#2468351>, @JVApen wrote:

> In D93490#2467733 <https://reviews.llvm.org/D93490#2467733>, @MyDeveloperDay wrote:
>
>> remove // = and // ~ cases
>
> Wouldn't it make sense to explicitly document that `//=` and `//~` are not put in here as reflowing them results in wrong results?

I think this would fit in a separate change which would also modify the documentation of `CommentPragmas`, so that who ever needs it could set that accordingly.

I'm currently trying to fix a misformating with `AlignConsecutiveDeclarations` with Qts `emit`, maybe there should be at Qt-Mode or something similar? As far as I can see there are some code paths to accommodate Qt.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93490/new/

https://reviews.llvm.org/D93490