[PATCH] D84924: [clang-tidy] Added command line option `fix-notes`

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:231
+/// If \p AnyFix is true and there is no FixIt attached to the Message,
+/// returns the first FixIt attached to any notes in the message.
+/// If no FixIt is found, returns nullptr.
----------------
Comment seems stale.


================
Comment at: clang-tools-extra/clang-tidy/misc/UnusedUsingDeclsCheck.cpp:186
-      // Emit a fix and a fix description of the check;
-      diag(Context.FoundUsingDecl->getLocation(),
-           /*Description=*/"remove the using", DiagnosticIDs::Note)
----------------
Should this change be a separate patch?


================
Comment at: clang-tools-extra/clang-tidy/readability/InconsistentDeclarationParameterNameCheck.cpp:222
 
-  auto ParamDiag =
-      Check->diag(Location,
----------------
Same for these changes?


================
Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:500
+  // --fix-errors and --fix-notes imply --fix.
+  FixBehaviour Behaviour = FixNotes             ? FB_FixNotes
+                           : (Fix || FixErrors) ? FB_Fix
----------------
Might as well fix this clang-format warning.


================
Comment at: clang-tools-extra/docs/clang-tidy/index.rst:176
                                      well.
+    --fix-notes                    - 
+                                     If a warning has no fix, but one of the 
----------------
This sort of reads like it may apply fixes from multiple notes. How about: `If a warning has no fix, but a single fix can be found through an associated diagnostic note, apply the fix. Specifying this flag will implicitly enable the '--fix' flag.`

(Note, I also quietly switched from using `` to using '' for quoting -- that seems to be the consistent style here.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84924/new/

https://reviews.llvm.org/D84924