[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 22 03:49:52 PST 2020


thakis added a comment.

This seems to break all tests on all platforms: http://45.33.8.238/linux/35854/step_7.txt

As far as I can tell, RenderSCPOptions is called unconditinoally and the error message is emitted at its start, before any Args.hasFlag checks -- so it's emitted every time a windows triple is passed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92245/new/

https://reviews.llvm.org/D92245



More information about the cfe-commits mailing list