[clang-tools-extra] 894c476 - [clangd] Add llvm:: qualifier to work around GCC bug. NFC

[David Blaikie via cfe-commits]

oh, fair - I didn't stop to notice this was over in
Clang/non-llvm-namespace'd code, so yeah, sounds good!

On Mon, Dec 21, 2020 at 10:49 PM Sam McCall <sam.mccall at gmail.com> wrote:

> Yeah. I don't actually know those details, the phab revision referenced
> (should have been a URL, oops) is all I know.
>
> The new version with the qualifier is better than the old one in any case
> though, so no need to ever remove it.
> (At least, we try to always spell the llvm qualifiers in clangd)
>
>
> On Tue, Dec 22, 2020, 2:26 AM David Blaikie <dblaikie at gmail.com> wrote:
>
>> Would be handy to include a comment to document which compiler version,
>> etc - so we know when we can remove this/don't waste time trying to remove
>> it too soon.
>>
>> On Thu, Dec 17, 2020 at 3:51 AM Sam McCall via cfe-commits <
>> cfe-commits at lists.llvm.org> wrote:
>>
>>>
>>> Author: Sam McCall
>>> Date: 2020-12-17T12:51:12+01:00
>>> New Revision: 894c4761c67ac850e156a26aa427035a811d7aed
>>>
>>> URL:
>>> https://github.com/llvm/llvm-project/commit/894c4761c67ac850e156a26aa427035a811d7aed
>>> DIFF:
>>> https://github.com/llvm/llvm-project/commit/894c4761c67ac850e156a26aa427035a811d7aed.diff
>>>
>>> LOG: [clangd] Add llvm:: qualifier to work around GCC bug. NFC
>>>
>>> Some old GCC versions seem to miss the default template parameter when
>>> using the clang/Basic/LLVM.h forward declarations of SmallVector.
>>>
>>> See D92788
>>>
>>> Added:
>>>
>>>
>>> Modified:
>>>     clang-tools-extra/clangd/Headers.h
>>>
>>> Removed:
>>>
>>>
>>>
>>>
>>> ################################################################################
>>> diff  --git a/clang-tools-extra/clangd/Headers.h
>>> b/clang-tools-extra/clangd/Headers.h
>>> index d86a4788f0a6..fd9db5562813 100644
>>> --- a/clang-tools-extra/clangd/Headers.h
>>> +++ b/clang-tools-extra/clangd/Headers.h
>>> @@ -136,7 +136,7 @@ class IncludeStructure {
>>>    unsigned fileIndex(llvm::StringRef Name);
>>>    llvm::StringMap<unsigned> NameToIndex; // Values are file indexes.
>>>    // Maps a file's index to that of the files it includes.
>>> -  llvm::DenseMap<unsigned, SmallVector<unsigned>> IncludeChildren;
>>> +  llvm::DenseMap<unsigned, llvm::SmallVector<unsigned>> IncludeChildren;
>>>  };
>>>
>>>  /// Returns a PPCallback that visits all inclusions in the main file.
>>>
>>>
>>>
>>> _______________________________________________
>>> cfe-commits mailing list
>>> cfe-commits at lists.llvm.org
>>> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201221/ec9d9af2/attachment.html>