[PATCH] D93638: [hip] Enable HIP compilation with `<complex`> on MSVC.

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 21 08:36:07 PST 2020


jdoerfert requested changes to this revision.
jdoerfert added a comment.
This revision now requires changes to proceed.

Disclaimer: I request changes because of the next sentence, other than that I have no objection but also cannot review this.
All `cuda_wrapper` headers say something about complex in the first row, copy & paste error. All have the wrong license text (I think).

---

> The device compilation should not relies on the host STL implementation.

The OpenMP one doesn't, at least not as much as the CUDA one. Unsure how that works on windows though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93638/new/

https://reviews.llvm.org/D93638



More information about the cfe-commits mailing list