[PATCH] D93638: [hip] Enable HIP compilation with `<complex`> on MSVC.

[Michael Liao via Phabricator via cfe-commits]

hliao added a comment.

Beyond the enabling of the compilation with `<complex>` on Windows, I really have the concern on the current approach supporting `<complex>` compilation in the device compilation. The device compilation should not relies on the host STL implementation. That results in inconsistent compilation results across various platforms, especially Linux vs. Windows.
BTW, the use of `<complex>` in CUDA cannot be compiled with NVCC directly even with `--expt-relaxed-constexpr`, c.f. https://godbolt.org/z/3f79co


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93638/new/

https://reviews.llvm.org/D93638