[PATCH] D93401: [flang][driver] Add support for `-D`, `-U`

Faris via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 21 07:57:08 PST 2020


FarisRehman marked an inline comment as done.
FarisRehman added inline comments.


================
Comment at: flang/lib/Frontend/CompilerInvocation.cpp:228
+      // Note: GCC drops anything following an end-of-line character.
+      llvm::StringRef::size_type End = MacroBody.find_first_of("\n\r");
+      MacroBody = MacroBody.substr(0, End);
----------------
tskeith wrote:
> This is a change in behavior from f18, right? If so, the commit message should mention it and why it's changing.
Updated the summary to address this, thanks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93401/new/

https://reviews.llvm.org/D93401



More information about the cfe-commits mailing list