[PATCH] D93543: clang-tidy: Leave the possibility of opting out having coloured diagnostic messages.
Nathan James via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Dec 21 04:56:58 PST 2020
njames93 added a comment.
Would it be wise to use `os.isatty(sys.stdout.fileno())` as the value if left unspecified.
As we capture stdout from clang-tidy, clang-tidy assumes we aren't connected to a terminal and thus disables colours, unless explicitly enabled.
Therefore if our python script is known to be running from a terminal and we haven't specified to use colours. We should enable `--use-color`.
Based off this, I think the argument should be a carbon copy of the `--use-color` option from clang-tidy.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93543/new/
https://reviews.llvm.org/D93543
More information about the cfe-commits
mailing list