[PATCH] D92160: [clang] Fix wrong FDs are used for files with same name in Tooling

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 18 13:32:56 PST 2020


dexonsmith added a comment.

In D92160#2453814 <https://reviews.llvm.org/D92160#2453814>, @OikawaKirie wrote:

> Replies from the original author Hao Zhang <zhanghao19 at ios.ac.cn>
>
> ---
>
> Sorry for replying late.
>
>> I think it would be good to understand why the tests failed. Are some clients relying on the name matching the query? If so, why?
>
> I'm currently working on this. Maybe try making `FileManager::getFileRef` always canonicalize to an absolute path, as you mentioned.

Sounds great; let me know how it goes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92160/new/

https://reviews.llvm.org/D92160



More information about the cfe-commits mailing list