[PATCH] D93540: [clang] Use enum for LangOptions::SYCLVersion instead of unsigned

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 18 13:17:01 PST 2020


dexonsmith added a comment.

I've reviewed the code and it seems to do the right thing. I'd like a SYCL maintainer to take a look too though.

(If for some reason changing the interface to an enum isn't desirable, maybe there's a compromise where there's an accessor that converts back to an integer?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93540/new/

https://reviews.llvm.org/D93540



More information about the cfe-commits mailing list