[PATCH] D93553: [clangd] Make our printing policies for Hover more consistent, especially tags
Quentin Chateau via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Dec 18 10:32:32 PST 2020
qchateau added a comment.
Looks good to me, it removes a lot of duplication and corner cases.
I'd have printed the tag for reference and pointers as well (`class Foo*` instead of `Foo*`). I don't think `Foo*` is much more understandable than `Foo`, so we decide that printing `class Foo` is easier to understand for the user, we should print `class Foo*` as well.
But I agree it's even less idiomatic, so I won't argue with your choice.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93553/new/
https://reviews.llvm.org/D93553
More information about the cfe-commits
mailing list