[PATCH] D93528: [clang-format] Add basic support for formatting JSON

Fri Dec 18 06:40:18 PST 2020

HazardyKnusperkeks added a comment.

In D93528#2462969 <https://reviews.llvm.org/D93528#2462969>, @MyDeveloperDay wrote:

> So I guess my question is:
>
> 1. is this useful to pursue (either as is, or by switching to us the reformat method)
> 2. is this useful standalone as the first pass
> 3. is adding support for JSON something people would welcome (as we did with C#)
>
> If the answer is no, then I don't want to waste the effort trying to fathom how we might do this inside reformat.

For me that's three times yes.

================
Comment at: clang/unittests/Format/FormatTestJson.cpp:14
+
+#define DEBUG_TYPE "format-test"
+
----------------
I don't know what's the practice right now. But I would suggest renaming that to "format-test-json", so you can see directly that's for JSON.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93528/new/

https://reviews.llvm.org/D93528