[PATCH] D93490: [clang-format] PR48539 ReflowComments breaks Qt translation comments

Björn Schäpers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 18 06:15:41 PST 2020


HazardyKnusperkeks added a reviewer: HazardyKnusperkeks.
HazardyKnusperkeks requested changes to this revision.
HazardyKnusperkeks added a comment.
This revision now requires changes to proceed.

I don't know if this really fixes the problem.

>From the Docs:

> An alternative way to attach meta-data is to use the following syntax:
>
> //~ <field name> <field contents>

With the example

  //~ loc-layout_id foo_dialog
  //~ loc-blank False
  //~ magic-stuff This might mean something magic.

So I would say breaking the `~` comment is a no go, but I would have to test it. (Which I can do next week.)
`//:` should be fine, `//=` would have the same problem, with the exception that it seems not to be used normally with long comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93490/new/

https://reviews.llvm.org/D93490



More information about the cfe-commits mailing list