[PATCH] D93102: [Clang][Sema] Detect section type conflicts between functions and variables

Thu Dec 17 08:44:33 PST 2020

aaron.ballman closed this revision.
aaron.ballman added a comment.

In D93102#2460034 <https://reviews.llvm.org/D93102#2460034>, @tmatheson wrote:

> In D93102#2458433 <https://reviews.llvm.org/D93102#2458433>, @aaron.ballman wrote:
>
>> LGTM aside from a minor nit. Thank you for the patch! Do you need me to commit on your behalf? If so, are you okay with `Tomas Matheson <Tomas.Matheson at arm.com>` for patch attribution?
>
> Thanks for the review. I will ask for commit access for future but if you could commit this one in the meantime that would be appreciated. That's fine for attribution.

I've commit on your behalf in f50066292477fb26806336e5604615d0eddde399 <https://reviews.llvm.org/rGf50066292477fb26806336e5604615d0eddde399>, thank you for the patch!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93102/new/

https://reviews.llvm.org/D93102