[PATCH] D93428: [AArch64] Add bti note property when compiling asm files with -mbranch-protection=bti

Thu Dec 17 08:32:06 PST 2020

steplong added a comment.

In D93428#2460032 <https://reviews.llvm.org/D93428#2460032>, @danielkiss wrote:

> The `.note.gnu.property` is already generated when C/C++ files are compiled with `-mbranch-protection=bti`.  
> `-mmark-bti-property` is only for assembly file where the `.note.gnu.property` should be added manually otherwise.
>
> Do you have any reproducer where C/C++ behaves unexpectedly?

I think Ana misunderstood the reason for this patch. We haven't seen any compilation of C/C++ behaving unexpectedly. -mbranch-protection=bti generates the .nute.gnu.property for C/C++ files from our experiments, but doesn't work for assembly files. Is there a reason why assembly files have a different flag (i.e. -mmark-bti-property) to create the .note.gnu.property with the BTI entry?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93428/new/

https://reviews.llvm.org/D93428