[PATCH] D86137: Add -Wno-error=unknown flag to clang-format.

[Joachim Meyer via Phabricator via cfe-commits]

fodinabor added a comment.

I can reproduce the issue, but not sure what introduced this.

In D86137#2460135 <https://reviews.llvm.org/D86137#2460135>, @njames93 wrote:

> Should the name be changed to `Wno-error-unknown`?

I don't think this should be the solution, as we aimed for the common syntax using the `-Wno-error=` style.
I just tried to prepare a patch, changing the way, this is handled, it works already in theory, but the formatting of the `--help` page is still slightly off (I guess `cl::values` descriptions are supposed to be single line), so I guess I have to investigate my formatting options here or move the more extensive description somewhere else... if I don't find an obvious solution, I guess we can discuss that after I created the patch..

  Clang-format options:
  
    --Werror                   - If set, changes formatting warnings to errors
    --Wno-error=<value>        - If set don't error out on the specified warning type.
      =unknown                 -   If set, unknown format options are only warned about.
  This can be used to enable formatting, even if the
  configuration contains unknown (newer) options.
  Use with caution, as this might lead to dramatically
  differing format depending on an option being
  supported or not.
    --assume-filename=<string> - Override filename used to determine the language.
                                 When reading from stdin, clang-format assumes this
                                 filename to determine the language.
    --cursor=<uint>            - The position of the cursor when invoking
  ...

Btw. is there a way to add tests for command line options, so this won't happen unnoticed again?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86137/new/

https://reviews.llvm.org/D86137