[PATCH] D92788: [clangd] NFC: Use SmallVector<T> where possible

Kirill Bobyrev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 16 10:58:00 PST 2020


kbobyrev added inline comments.


================
Comment at: clang-tools-extra/clangd/Headers.h:139
   // Maps a file's index to that of the files it includes.
-  llvm::DenseMap<unsigned, SmallVector<unsigned, 8>> IncludeChildren;
+  llvm::DenseMap<unsigned, SmallVector<unsigned>> IncludeChildren;
 };
----------------
arphaman wrote:
> It looks like the change on this line is failing to compile on Ubuntu 16.04 with the System GCC. (https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-16_04-next/23655/console).
> 
> Can I reinstate the `llvm::DenseMap<unsigned, SmallVector<unsigned, 8>>` for now until we drop support for Ubuntu 16.04?
Uh, didn't see that one, I'm sorry to hear that. Yes, sure, feel free to change it to make your setup work!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92788/new/

https://reviews.llvm.org/D92788



More information about the cfe-commits mailing list