[PATCH] D93102: [Clang][Sema] Detect section type conflicts between functions and variables

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM aside from a minor nit. Thank you for the patch! Do you need me to commit on your behalf? If so, are you okay with `Tomas Matheson <Tomas.Matheson at arm.com>` for patch attribution?



================
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:3086-3087
     D->addAttr(NewAttr);
+    if (isa<FunctionDecl>(D) || isa<FunctionTemplateDecl>(D) ||
+        isa<ObjCMethodDecl>(D) || isa<ObjCPropertyDecl>(D))
+      S.UnifySection(NewAttr->getName(),
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93102/new/

https://reviews.llvm.org/D93102