[PATCH] D93398: [NFC] Use regex for code object version in hip tests
Tony Tye via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Dec 16 07:58:17 PST 2020
t-tye added inline comments.
================
Comment at: clang/test/Driver/hip-code-object-version.hip:56
-// V4: "-mllvm" "--amdhsa-code-object-version=4"
-// V4: "-targets=host-x86_64-unknown-linux,hip-amdgcn-amd-amdhsa--gfx906"
+// VD: "-mllvm" "--amdhsa-code-object-version=4"
+// VD: "-targets=host-x86_64-unknown-linux,hip-amdgcn-amd-amdhsa--gfx906"
----------------
t-tye wrote:
> If the upstream default is being changed to 3 does this need to also be 3?
I can also help getting this landed in to internal branches.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93398/new/
https://reviews.llvm.org/D93398
More information about the cfe-commits
mailing list