[PATCH] D93258: [amdgpu] Default to code object v3

Wed Dec 16 07:50:35 PST 2020

JonChesterfield added a comment.

In D93258#2457905 <https://reviews.llvm.org/D93258#2457905>, @yaxunl wrote:

> Thanks for fixing the lit tests. Using regex is the right choice.
>
> Do we have a plan about how to merge this to amd-stg-open? Will it cause ePSDB to fail? Do you have a follow up patch to make amd-stg-open happy?
>
> Thanks.

Extracted as D93398 <https://reviews.llvm.org/D93398>. Suggest we land that, then it flows into gerrit (where it won't break anything), and rebase this patch to reduce the noise.

This will need to be merged carefully into amd-stg-open if the intent is to continue using v4 as the default on the internal branch. No follow up patch necessary, the trick would be to not land this.

Note that none of this would be necessary if trunk clang hadn't been prematurely updated to default to a code object version that llvm trunk doesn't use.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93258/new/

https://reviews.llvm.org/D93258